Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sea ice metrics beta #1024

Merged
merged 78 commits into from
Jan 26, 2024
Merged

Sea ice metrics beta #1024

merged 78 commits into from
Jan 26, 2024

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented Jan 25, 2024 •
edited
Loading

Adding the beta sea ice driver and tutorial

lee1043 and others added 30 commits November 7, 2023 09:52
@lee1043
initial commit
c3a6cf1
@lee1043
style fix (pre-commit)
5c7b40c
@lee1043
python 2 style to python 3 style, pre-commit fix
7e7cc6f
@lee1043
explicit import for functions
7d3e823
@lee1043
pre-commit fix: do not use bare except
62de671
@lee1043
clean up
ef09d8f
@lee1043
clean up
dae3443
@lee1043
Merge branch 'main' into 405_sic_ljw
985fcee
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into main
d3114fe
Merge branch '405_sic_ljw' of https://github.com/PCMDI/pcmdi_metrics …
f5dd791 
…into 405_sic_ao
add file names
46b955c
update regions
9b3a27a
add changes
752d343
first draft
6aac671
changes
809882f
more updates
1d4b654
Merge branch 'bug/1009_lee1043_landmask' of https://github.com/PCMDI/…
8c5ccce 
…pcmdi_metrics into 405_sic_ao
changes
ecd5e5a
add parameter file
c475586
changes
123313a
more fixes
8186e15
new cases
d0f9a0b
add file
724fe34
Merge branch 'main' of https://github.com/PCMDI/pcmdi_metrics into 40…
502948c 
…5_sic_ao
add readme
3177b35
fix formatting
c97bc29
Merge branch 'feature/1012_lee1043_stats' of https://github.com/PCMDI…
36e9366 
…/pcmdi_metrics into 405_sic_ao
fix coord issues
c9ef21e
update for symlinks
50085d4
fix formatting
50da0c3
@acordonez acordonez requested a review from lee1043 January 25, 2024 22:02
@lee1043
Copy link
Contributor

lee1043 commented Jan 25, 2024

Can you add __init__.py file in the https://github.com/PCMDI/pcmdi_metrics/tree/405_sic_ao/pcmdi_metrics/sea_ice/lib?

@acordonez
Copy link
Collaborator Author

@lee1043 Added!

@durack1
Copy link
Collaborator

durack1 commented Jan 26, 2024

Just adding myself to watch - was hoping to update email template and send later tonight (as we received the email from Younjoo)

@lee1043
Copy link
Contributor

lee1043 commented Jan 26, 2024

@acordonez thank you for the excellent work in tight timeline! This is really great. I was able to run the notebook without any issues. I just added a minor update to add wall clock time, as @durack1 suggested. nc-time-axis that was needed for the plotting part was added to dev.yml. I am merging this to the main branch.

Once merged, @durack1 and @acordonez, would you try run this through the binder hub? I will do so as well.

@lee1043 lee1043 merged commit 43dab6b into main Jan 26, 2024
5 checks passed
@lee1043 lee1043 added this to the 3.3 milestone Jan 26, 2024
@lee1043 lee1043 linked an issue Jan 26, 2024 that may be closed by this pull request
Sector scale sea-ice (Ivanova et al., 2016) #405
Closed
@lee1043 lee1043 deleted the 405_sic_ao branch January 26, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee1043 lee1043 lee1043 approved these changes

Assignees

@acordonez acordonez

Labels
demo enhancement New feature
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

Sector scale sea-ice (Ivanova et al., 2016)
3 participants
@acordonez @lee1043 @durack1